Skip to content
This repository was archived by the owner on Sep 25, 2021. It is now read-only.

"nodash" and "nayQuery"#2

Open
schmamps wants to merge 4 commits intowkallhof:masterfrom
schmamps:nodash
Open

"nodash" and "nayQuery"#2
schmamps wants to merge 4 commits intowkallhof:masterfrom
schmamps:nodash

Conversation

@schmamps
Copy link

@schmamps schmamps commented Feb 22, 2017

I use this code in another project. Just thought I'd fix some of it and remove the dependencies. It's mostly functional changes, not style or formattting.

It's mentioned in the diff, but the only real issue I see is that lodash has a different way of sorting, so words with the same score may not come out in the same order as before.

Summarizer

  • fixed a typo in comments
  • replaced lodash methods with ES5 Array methods (it feels pretty safe to use these now).

Tokenizer

  • fixed bug where sentences would sometimes repeat the first word

Example

  • removed cruft
  • replaced jQuery with vanilla scripting

Readme

  • Removed the dependency TODO

Libraries

  • removed jQuery
  • removed lodash

@Explosion-Scratch
Copy link

Lol what is nayQuery and nodash? lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants