Open
Conversation
idoros
reviewed
Jan 4, 2024
Contributor
idoros
left a comment
idoros
left a comment
There was a problem hiding this comment.
there are several upgrades and fixes the rollup integration has had since this was copied, it might be worth it to migrate these changes
| clearScreen: false, | ||
| }; | ||
|
|
||
| async function viteBuildAndPreview() { |
Contributor
There was a problem hiding this comment.
would be nice to extract to a basic test-kit to share between the 2 specs
| "!*/tsconfig.{json,tsbuildinfo}" | ||
| ], | ||
| "engines": { | ||
| "node": ">=16" |
Contributor
There was a problem hiding this comment.
Suggested change
| "node": ">=16" | |
| "node": ">=18.12.0" |
| Plugin['transform'] extends ObjectHook<infer T, {}> ? NonNullable<T> : false | ||
| >; | ||
|
|
||
| export function generateStylableModuleCode( |
Contributor
There was a problem hiding this comment.
notice that on master this was refactored to a common place between integrations
| * string - it will use the provided string as the "stcConfig" file path. | ||
| */ | ||
| stcConfig?: boolean | string; | ||
| projectRoot?: string; |
Contributor
There was a problem hiding this comment.
the rollup integration this was copied from now supports a better default for handling side-effects: includeGlobalSideEffects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Stylable integration plugin for vite.
Currently does not include a CSA template.