Created a plan for supporting any trigger in Interact#146
Open
Created a plan for supporting any trigger in Interact#146
Conversation
ameerabuf
reviewed
Mar 10, 2026
packages/interact/src/types.ts
Outdated
| listContainer?: string; | ||
| listItemSelector?: string; | ||
| trigger: TriggerType; | ||
| trigger: |
Contributor
There was a problem hiding this comment.
this union types are annoying and impossible to work with.. I think it is time to implement a generic OneOf template
Collaborator
Author
There was a problem hiding this comment.
@ameerabuf ok, can you give a suggestion?
Collaborator
Author
|
This design is currently stuck since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New Plan for allowing Interact to work with any trigger provided via
triggerin the Config.