Add from_reader for types implementing Read and Seek#17
Open
withbitsinmind wants to merge 1 commit into
Open
Conversation
Fix handling of files larger than 0x20000 (131,072 bytes) in ZipSpecialHandler and OleSpecialHandler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes handling of files larger than 0x20000 (131,072 bytes) in
ZipSpecialHandlerandOleSpecialHandler.Large files are truncated to 131,072 bytes before being passed to
ZipArchive::new. Since ZIP archives store their central directory at the end of the file, the truncated input results in an error which is silently ignored. UsingRead + Seekall the way through ensures the full file can be accessed and correctly processed, in addition to providing a more flexible API than juststd::fs::File.