feat: add progress for initializing server#412
Open
PeterCardenas wants to merge 1 commit intowithered-magic:mainfrom
Open
feat: add progress for initializing server#412PeterCardenas wants to merge 1 commit intowithered-magic:mainfrom
PeterCardenas wants to merge 1 commit intowithered-magic:mainfrom
Conversation
Owner
|
will also take a look at this today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a progress indicator while the server is starting up. The initial bazel commands can take some time, but whether they're in progress is opaque. This gives feedback on their progress in addition to whether they fail.
Note, we can't use
self.send_notificationand the task pool here, because tasks only get accepted once the server is started up.