fix: warn when unsupported parameters are silently ignored#212
Merged
Kamilbenkirane merged 2 commits intomainfrom Mar 19, 2026
Merged
fix: warn when unsupported parameters are silently ignored#212Kamilbenkirane merged 2 commits intomainfrom
Kamilbenkirane merged 2 commits intomainfrom
Conversation
Fixes #210 Add UnsupportedParameterWarning emitted via warnings.warn() when a user passes a parameter that has no mapper for the current provider/model.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…aram detection Each mapper claims its parameter via pop(). Unclaimed params are naturally what remains, removing the need for a separate set + loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #210
UnsupportedParameterWarning(UserWarning)custom warning classwarnings.warn()in_build_request()when a user passes a parameter that has no mapper for the current provider/modelwarnings.filterwarnings("ignore", category=UnsupportedParameterWarning)or promote to error with"error"Test plan
None