Skip to content

Update to go 1.19#644

Merged
jasikpark merged 12 commits intomainfrom
update-to-go-1.19
Dec 7, 2022
Merged

Update to go 1.19#644
jasikpark merged 12 commits intomainfrom
update-to-go-1.19

Conversation

@jasikpark
Copy link
Copy Markdown
Contributor

@jasikpark jasikpark commented Nov 20, 2022

Needed for #619

Changes

  • Upgrades Go to 1.19

Testing

dep upgrade

Docs

dep upgrade

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 094b539

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jasikpark jasikpark requested a review from natemoo-re November 20, 2022 01:07
@jasikpark
Update to go 1.19
808a163 
Derp realized I need this for my fuzzing PR, since fuzzing is only supported as of 1.18
@jasikpark
Copy link
Copy Markdown
Contributor Author

jasikpark commented Nov 20, 2022

golang/go#50310 merh

@jasikpark
Copy link
Copy Markdown
Contributor Author

jasikpark commented Nov 20, 2022 •
edited
Loading

gonna see if there's a https://github.com/norunners/vert 1.19 version ig?
https://github.com/natemoo-re/vert

PR attempting a fix: norunners/vert#17

@jasikpark
Copy link
Copy Markdown
Contributor Author

jasikpark commented Dec 4, 2022

okay, norunners/vert#19 was merged, maybe @natemoo-re you can rebase your fork on it && we can upgrade natemoo-re/vert?

@natemoo-re
Copy link
Copy Markdown
Member

natemoo-re commented Dec 4, 2022

Awesome, thanks @jasikpark! I'll take a look tomorrow!

@jasikpark
Copy link
Copy Markdown
Contributor Author

jasikpark commented Dec 7, 2022

hopefully there's not fundamental refactoring w/ how we use ValueOf 😅

@natemoo-re
Copy link
Copy Markdown
Member

natemoo-re commented Dec 7, 2022 •
edited
Loading

hopefully there's not fundamental refactoring w/ how we use ValueOf 😅

Seems like we just needed to unwrap the value first!

natemoo-re
natemoo-re approved these changes Dec 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking the lead on this ❤️

@jasikpark
Copy link
Copy Markdown
Contributor Author

jasikpark commented Dec 7, 2022

Had to get it in for my fuzzer #619 xD

jasikpark
jasikpark commented Dec 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! glad i won't need to load a custom golang version for testing/building now

@jasikpark jasikpark requested a review from natemoo-re December 7, 2022 20:10
@jasikpark jasikpark merged commit abdddeb into main Dec 7, 2022
@jasikpark jasikpark deleted the update-to-go-1.19 branch December 7, 2022 20:12
@jasikpark jasikpark mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natemoo-re natemoo-re Awaiting requested review from natemoo-re

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasikpark @natemoo-re