-
Notifications
You must be signed in to change notification settings - Fork 1
Multiple enhancements #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Promtail role now always executes its setup tasks and the config template conditionally includes a Loki `remote_write` client when `loki_remote_write` is defined, enabling log pushing to a remote Loki instance. Additionally, the `force` parameter in the download task was changed from the string "no" to the boolean `false` for correct usage.
Switch the coredns role to use official CoreDNS releases instead of building from source, create a dedicated system user and group, and update the Corefile template to obtain the Nomad management token from the primary Nomad master node. Documentation is extended with a Nomad cluster mode section and the golang role is removed from the playbook.
Add a dedicated entrypoint for Traefik's metrics at port 8081 and update the Prometheus scrape configuration to rewrite the target address. This separates metric traffic from the main HTTPS entrypoint.
Replace the static Nomad address with a Jinja2 expression that pulls the address from Ansible hostvars, defaulting to 127.0.0.1. This makes the Traefik configuration dynamic and adaptable to different environments.
Introduce a new Ansible role to install and manage the NVIDIA GPU Exporter. The role includes defaults (disabled by default), handlers to restart the service, build tasks that download and install the binary, systemd service template, and upstream variable handling for version detection. This enables optional deployment of the exporter on hosts with NVIDIA GPUs.
- Convert quoted string booleans to native boolean values across defaults and templates. - Add dynamic TLS SAN IP range generation and expose it via `nomad_tls_ip_range`. - Enable Docker private registry support and simplify Docker TLS handling. - Restructure certificate copy tasks to use loops for server and client nodes. - Comment out S3 storage plugin job templates and its handler flush. - Disable CNI installation task and update related conditionals. - Update various template files to use lower‑cased boolean rendering. BREAKING CHANGE: S3 storage plugin is disabled by default and boolean handling has changed; existing playbooks or roles that relied on the previous string representations or S3 plugin may need adjustment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main improvements added to this PR are: