Skip to content

chore: remove dead non multibackend code paths - WPB-12140 #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
netbe wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

chore: remove dead non multibackend code paths - WPB-12140 #3975

netbe wants to merge 36 commits into from
+93 −713

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Dec 4, 2025 •
edited
Loading

TaskWPB-12140 [iOS] Clean up legacy BackendEnvironment code

Issue

This is one of the PRs removing multibackend dead code, this one focus on removing direct dead code:

  • remove DeveloperFlag.multibackend
  • SharingSession convenience initializers

Next:

  • BackendEnvironment2 to be rename
  • remove WireTransport.BackendEnvironment
  • remove APIVersionResolver
  • remove dead AuthenticationCoordinator cases

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe changed the base branch from develop to chore/remove-oldblacklist December 7, 2025 15:10
@netbe netbe force-pushed the chore/remove-multibackend branch from c764afa to 5552957 Compare December 7, 2025 15:11
@netbe netbe changed the title chore: remove multibackend chore: remove dead non multibackend code paths - WPB-12140 Dec 8, 2025
@netbe netbe force-pushed the chore/remove-multibackend branch from 5552957 to f9e1589 Compare December 10, 2025 09:10
Base automatically changed from chore/remove-oldblacklist to develop December 11, 2025 12:28
@netbe netbe force-pushed the chore/remove-multibackend branch from a0fcfc1 to f9e1589 Compare December 16, 2025 14:26
@netbe netbe marked this pull request as ready for review December 17, 2025 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025 •
edited
Loading

Test Results

1 954 tests   1 925 ✅  2m 25s ⏱️
  322 suites     27 💤
    2 files        2 ❌

For more details on these failures, see this check.

Results for commit aecb0d3.

♻️ This comment has been updated with latest results.

@netbe netbe requested a review from johnxnguyen December 18, 2025 15:39
@netbe netbe requested a review from David-Henner December 18, 2025 15:39
@netbe netbe changed the base branch from develop to fix/slow-request-strategies-tests-cherry-pick December 19, 2025 14:53
Base automatically changed from fix/slow-request-strategies-tests-cherry-pick to develop December 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnxnguyen johnxnguyen Awaiting requested review from johnxnguyen

@David-Henner David-Henner Awaiting requested review from David-Henner

At least 2 approving reviews are required to merge this pull request.

Assignees

@netbe netbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@netbe