-
Notifications
You must be signed in to change notification settings - Fork 25
fix: show apps tab for legacy bots - WPB-21441 #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
caldrian
wants to merge
155
commits into
develop
Choose a base branch
from
fix/show-apps-tab-for-legacy-bots-WPB-21441
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+613
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1' into feat/hint-banner-for-disabled-apps-WPB-21441-cherry-pick
…pps-tab-for-legacy-bots-WPB-21441
…banner-for-disabled-apps-WPB-21441-cherry-pick # Conflicts: # WireUI/Sources/WireIndividualToTeamMigrationUI/Views/SelfProfileViewCallToActionBanner.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/ConversationCreationController.swift
…pps-tab-for-legacy-bots-WPB-21441 # Conflicts: # WireUI/Sources/WireIndividualToTeamMigrationUI/Views/SelfProfileViewCallToActionBanner.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/ConversationCreationController.swift
…k' into fix/show-apps-tab-for-legacy-bots-WPB-21441
…com:wireapp/wire-ios into fix/show-apps-tab-for-legacy-bots-WPB-21441
…pps-tab-for-legacy-bots-WPB-21441
…banner-for-disabled-apps-WPB-21441-cherry-pick
…k' into fix/show-apps-tab-for-legacy-bots-WPB-21441
…w-apps-tab-for-legacy-bots-WPB-21441 # Conflicts: # wire-ios-utilities/Source/DeveloperFlag.swift # wire-ios/Wire-iOS/Sources/UserInterface/MainController/DefaultManagedObjectContextProvider.swift # wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/StartUIViewController.swift
…banner-for-disabled-apps-WPB-21441-cherry-pick
…1-0ed7da7872ca5db6f2ed0b956c8b87e044059413' into feat/hint-banner-for-disabled-apps-WPB-21441-cherry-pick
…k' into fix/show-apps-tab-for-legacy-bots-WPB-21441 # Conflicts: # WireMessaging/Sources/WireMessagingData/WireMessagingData.swift # WireMessaging/Sources/WireMessagingDomain/WireCells/Protocols/WireCellsRestoreNodesUseCaseProtocol.swift # wire-ios/Wire-iOS/Sources/UserInterface/MainController/DefaultManagedObjectContextProvider.swift # wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/StartUIViewController.swift
…considerapps-dev-flag-WPB-21441
…1-0ed7da7872ca5db6f2ed0b956c8b87e044059413' into chore/add-considerapps-dev-flag-WPB-21441
…w-apps-tab-for-legacy-bots-WPB-21441 # Conflicts: # WireMessaging/Sources/WireMessagingDomain/WireCells/Protocols/WireCellsRestoreNodesUseCaseProtocol.swift
…ersationCreationRepository-WPB-21441
…x/show-apps-tab-for-legacy-bots-WPB-21441
…pps-tab-for-legacy-bots-WPB-21441
d71897f to
577290d
Compare
714843d to
a2c94ac
Compare
…pps-tab-for-legacy-bots-WPB-21441
caldrian
commented
Dec 19, 2025
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
David-Henner
approved these changes
Dec 19, 2025
...re-iOS/Sources/UserInterface/Conversation Options/ConversationServicesOptionsViewModel.swift
Outdated
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
netbe
approved these changes
Dec 19, 2025
Collaborator
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left a couple questions and suggestions
wire-ios/Wire-iOS/Sources/UserInterface/Conversation Options/TitleBodyCellPreview.swift
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Outdated
Show resolved
Hide resolved
...face/Conversation/ConversationViewController+ConversationContentViewControllerDelegate.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
Show resolved
Hide resolved
...ios/Wire-iOS/Sources/UserInterface/GroupDetails/Sections/GroupOptionsSectionController.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/MainController/ZClientViewController.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/StartUI/StartUI/StartUIViewController.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/UserProfile/ProfileViewController.swift
Show resolved
Hide resolved
…pps-tab-for-legacy-bots-WPB-21441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR makes sure that the UI for starting 1:1 conversations and searching for bots is visible even if the new
appsfeature flag is disabled. Teams/customers who were using old-style services/bots should be able to keep using them.Testing
Open the UI for creating a new conversation. If there are bots whitelisted for a team, there will be a UI for starting a 1:1 conversation with a bot.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: