Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 16, 2026

TaskWPB-22556 [Kalium] Create common contracts for Use Cases - Return types


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adapt changes for


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 48.64865% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.60%. Comparing base (62af2df) to head (312245c).

Files with missing lines Patch % Lines
...etails/editguestaccess/EditGuestAccessViewModel.kt 12.50% 6 Missing and 1 partial ⚠️
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% 3 Missing and 1 partial ⚠️
...kmanager/worker/DeleteConversationLocallyWorker.kt 0.00% 2 Missing and 1 partial ⚠️
...rsations/messages/ConversationMessagesViewModel.kt 33.33% 2 Missing ⚠️
...on/broadcastreceivers/NotificationReplyReceiver.kt 0.00% 1 Missing ⚠️
...i/debug/conversation/DebugConversationViewModel.kt 0.00% 1 Missing ⚠️
.../conversations/sendmessage/SendMessageViewModel.kt 83.33% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (48.64%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4535   +/-   ##
========================================
  Coverage    48.60%   48.60%           
========================================
  Files          573      573           
  Lines        19729    19741   +12     
  Branches      3300     3308    +8     
========================================
+ Hits          9589     9596    +7     
- Misses        9128     9130    +2     
- Partials      1012     1015    +3     
Files with missing lines Coverage Δ
...e/android/ui/home/gallery/MediaGalleryViewModel.kt 63.46% <100.00%> (+0.23%) ⬆️
.../ui/userprofile/service/ServiceDetailsViewModel.kt 94.93% <100.00%> (ø)
...on/broadcastreceivers/NotificationReplyReceiver.kt 2.94% <0.00%> (ø)
...i/debug/conversation/DebugConversationViewModel.kt 0.00% <0.00%> (ø)
.../conversations/sendmessage/SendMessageViewModel.kt 78.92% <83.33%> (+0.10%) ⬆️
...rsations/messages/ConversationMessagesViewModel.kt 66.66% <33.33%> (+0.17%) ⬆️
...kmanager/worker/DeleteConversationLocallyWorker.kt 1.92% <0.00%> (-0.04%) ⬇️
...i/debug/featureflags/DebugFeatureFlagsViewModel.kt 0.00% <0.00%> (ø)
...etails/editguestaccess/EditGuestAccessViewModel.kt 76.11% <12.50%> (-2.35%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62af2df...312245c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants