Skip to content

chore: remove old entity traits impls [wpb-22196] #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
coriolinus wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

chore: remove old entity traits impls [wpb-22196] #1748

coriolinus wants to merge 18 commits into from

Conversation

@coriolinus
Copy link
Contributor

@coriolinus coriolinus commented Jan 15, 2026

What's new in this PR

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

🐰 Bencher Report

Branchprgn/chore/22196-remove-old-entity-traits-impls
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
Commit add f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		14,004.00 µs
Commit add f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		719.19 µs
Commit add f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		4,065.10 µs
Commit add f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		6,289.50 µs
Commit add f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		9,633.10 µs
Commit add f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		11,881.00 µs
Commit add f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		803,170.00 µs
Commit add f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		724.92 µs
Commit add f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		67,685.00 µs
Commit add f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		176,270.00 µs
Commit add f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		343,500.00 µs
Commit add f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		552,860.00 µs
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		91,162.00 µs
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		19,189.00 µs
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		33,928.00 µs
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		45,441.00 µs
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		60,396.00 µs
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		72,522.00 µs
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
⚠️ NO THRESHOLD		14,165.00 µs
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
⚠️ NO THRESHOLD		90,493.00 µs
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
⚠️ NO THRESHOLD		27,632.00 µs
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
⚠️ NO THRESHOLD		44,900.00 µs
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
⚠️ NO THRESHOLD		59,371.00 µs
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
⚠️ NO THRESHOLD		75,436.00 µs
Commit remove f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		9,347.10 µs
Commit remove f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		496.58 µs
Commit remove f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		1,852.60 µs
Commit remove f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		3,288.80 µs
Commit remove f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		5,041.30 µs
Commit remove f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		6,655.90 µs
Commit remove f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		11,504.00 µs
Commit remove f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		116,930.00 µs
Commit remove f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		95,762.00 µs
Commit remove f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		74,852.00 µs
Commit remove f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		53,660.00 µs
Commit remove f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		32,683.00 µs
Commit update f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		116,330.00 µs
Commit update f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		652.62 µs
Commit update f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		24,030.00 µs
Commit update f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		47,346.00 µs
Commit update f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		71,202.00 µs
Commit update f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		93,631.00 µs
🐰 View full continuous benchmarking report in Bencher

@coriolinus coriolinus force-pushed the prgn/chore/22196-remove-old-entity-traits-impls branch 2 times, most recently from 78d9221 to f22fe4d Compare January 15, 2026 15:42
@coriolinus
chore(keystore): use new entity traits in a few more places
3b66d61
@coriolinus
chore(keystore): use new entity traits in wasm migrations
53df71e 
Makes `V6Credential` public to allow its use in a pub trait

As it appears as an associated type in a trait, it must be public.
@coriolinus
chore(crypto): use the new entity api in more places
232134b
@coriolinus
chore(macros): delete old entity macro
4a82650
@coriolinus
chore(keystore): rm usage of old entity macro
d129a5e
@coriolinus
chore(keystore): rm old entity traits
d7dedc0
@coriolinus
chore(keystore): rm old entity trait impls
f11d234
@coriolinus
chore(keystore): rm MissingKeyErrorKind
4fe8631 
New entity traits use `Option` instead of an error variant to indicate
absence, or a `bool` in the case of a delete. We don't need these
pointless error variants; the caller knows what kind of thing they
had been looking for.
@coriolinus
chore(keystore): rm old rekey_entities macro
ec32d2e
@coriolinus
chore(keystore): use new entity traits in more places and downstream …
cff3982 
…functions

We're at the point of 2nd-order effects now.
@coriolinus
chore(keystore/test): adapt to new entity traits
8136024
@coriolinus
chore: rename all entity-related new_foo to foo
2d31691 
Also all variations of that pattern.
@coriolinus
chore(keystore): rm entity-implementaiton worked examples
d10e769 
These examples were used during the initial design of the new entity
traits and during development of the new entity implementaiton macro.
However, at this point those designs are effectively locked, and these
examples are not actually used for anything; pure dead code. So we
get rid of them.
@coriolinus
fixup! chore: rename all entity-related new_foo to foo
9e62442
@coriolinus
chore: rm all usage of cfg_if!
5cdd362 
This macro has two major downsides:

- by moving into a macro context from a `cfg`-context, it degrades IDE experience
- it encourages grouping large blocks by configuration, not by item

So IMO it is bad practice, and I'm excited to remove it
@coriolinus
chore: rm cfg-if dependency
9be2864
@coriolinus
wip: figure out how to emit debug info
6bdad14
@coriolinus coriolinus force-pushed the prgn/chore/22196-remove-old-entity-traits-impls branch from f22fe4d to 6bdad14 Compare January 19, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coriolinus