update side-by-side example to match the current official recommendations on how to write redux code#2
Open
phryneas wants to merge 1 commit intowire-ts:masterfrom
Open
Conversation
…ions on how to write redux code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing your library to a style of Redux that isn't actively recommended in the official style guide or taught in the official tutorials seems a little unfair. This updates the Redux part to the officially recommended style of writing & learning Redux nowadays
See The Redux Style Guide, The "Modern Redux" part of the "Fundamentials" tutorial, The full "Essentials" tutorial
Obviously I assume this would also change most of the wording on this page, but I'm already happy if the code itself is up-to-date.