Massively buff lux absorption of reinforced glass.#2
Open
Byrnorthil wants to merge 1 commit intowintersknight94:mainfrom
Open
Massively buff lux absorption of reinforced glass.#2Byrnorthil wants to merge 1 commit intowintersknight94:mainfrom
Byrnorthil wants to merge 1 commit intowintersknight94:mainfrom
Conversation
A lux-absorb value of 20 provides 20/64 absorption, or just over 31%. This value is likely much lower than WintersKnight intended, and is in fact less than half as effective as the 83% absorption it would have due to its cracky value if the line was omitted. I've given it the metallic group (100% absorption) as that seems to be the intention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(from commit message): "A lux-absorb value of 20 provides 20/64 absorption, or just over 31%. This value is likely much lower than WintersKnight intended, and is in fact less than half as effective as the 83% absorption it would have due to its cracky value if the line was omitted. I've given it the metallic group (100% absorption) as that seems to be the intention."
Radiation logic is here; lines 72-87 are most important in this case. In the future, I would suggest more thorough research, rather than making up a number which feels right. Testing of the rad blocking in-game would also reveal mistakes like this.
...this is all assuming you actually want the glass to be good at blocking rad. If not, hats off for the bamboozlement.