feat: add required id field to ServiceInfo#8
Merged
Conversation
Add a required `id` field to ServiceInfo using slug format (lowercase alphanumeric with hyphens). This ID is sent to the orchestrator during registration, making registration idempotent and providing a predictable identifier for use in chap-core. Changes: - Add `id` field to ServiceInfo with slug format validation - Update registration.py to use info.id instead of orchestrator-assigned ID - Include id in registration payload sent to orchestrator - Update all examples to include id field - Add validation tests for id format - Update documentation with id field examples BREAKING CHANGE: ServiceInfo now requires an `id` field
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idfield toServiceInfowith slug format validationidfieldChanges
ServiceInfo
idfield with slug format validation (^[a-z][a-z0-9]*(-[a-z0-9]+)*$)my-service,chap-ewars,prediction-serviceMy-Service(uppercase),my_service(underscore),1-service(starts with number)Registration
idfield fromServiceInfoVersion
BREAKING CHANGE
All existing
ServiceInfousages must add theidfield:Test plan
make test)make lint)