Skip to content

fix: added two fields to MlServiceInfo that we needed in chap #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivargr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: added two fields to MlServiceInfo that we needed in chap #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faa612c
fix: added two fields to MlServiceInfo that we needed in chap
ivargr Oct 20, 2025
36075e5
Writing config file to yaml instad of json in ShellModelRunner
ivargr Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/chapkit/api/service_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ class MLServiceInfo(ServiceInfo):
organization: str | None = None
organization_logo_url: HttpUrl | None = None
citation_info: str | None = None
allow_free_additional_continuous_covariates: bool = False
required_covariates: List[str] = field(default_factory=list)


@dataclass(slots=True)
Expand Down
12 changes: 10 additions & 2 deletions src/chapkit/modules/ml/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ async def on_train(
config_file = temp_dir / "config.json"
config_file.write_text(json.dumps(config.model_dump(), indent=2))

# Write config to YAML
config_file_yaml = temp_dir / "config.yaml"
config_file_yaml.write_text(config.model_dump_yaml())


# Write training data to CSV
data_file = temp_dir / "data.csv"
data.to_csv(data_file, index=False)
Expand All @@ -137,7 +142,7 @@ async def on_train(

# Substitute variables in command
command = self.train_command.format(
config_file=str(config_file),
config_file=str(config_file_yaml),
data_file=str(data_file),
model_file=str(model_file),
geo_file=str(geo_file) if geo_file else "",
Expand Down Expand Up @@ -194,6 +199,9 @@ async def on_predict(
config_file = temp_dir / "config.json"
config_file.write_text(json.dumps(config.model_dump(), indent=2))

config_file_yaml = temp_dir / "config.yaml"
config_file_yaml.write_text(config.model_dump_yaml())

# Write model to file
model_file = temp_dir / f"model.{self.model_format}"
with open(model_file, "wb") as f:
Expand All @@ -220,7 +228,7 @@ async def on_predict(

# Substitute variables in command
command = self.predict_command.format(
config_file=str(config_file),
config_file=str(config_file_yaml),
model_file=str(model_file),
historic_file=str(historic_file) if historic_file else "",
future_file=str(future_file),
Expand Down
Loading