Convert various vars and functions to const
#99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `const` variables instead. Also mark various functions as `const fn`
…ually correct, so I'm doing this.
Collaborator
Author
|
requesting a review bc I'm not 100% sure there won't be any unintended side effects, so I just want a second pair of eyes on this |
sohpeach
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
Valuefunctions are now const variables instead.The previous functions still exist, but are just thin wrappers around the variables, and are marked as deprecated.
Value::globals()->Value::GLOBALValue::world()->Value::WORLDValue::null()->Value::NULLAlso, I added the
clippy::missing_const_for_fnlint, and marked anything it pointed out asconst.