Skip to content

Conversation

@chrisbrookes
Copy link

The 'real' checks weren't so useful for me so I've added no cache/buffer versions.

@willixix
Copy link
Owner

Hi Chris,

I have not decided yet if I'm going to merge this into branch because it'd require changing graph templates distributed with this plugin. I do agree that some people will find these more useful than what is included. But the plugin is written as an example so that adding new expressions like you did for those who need is easy since they are just one-liner definitions. So these are really more like examples of config customizations than a plugin code. One possibility is simply including yours in the plugin but having them commented out and those who need it would un-comment. I'll think about it more and test if adding these would break graphing or not. I do thank you for your willingness contribute.

Regards,

William

@chrisbrookes
Copy link
Author

No problem, I did what I needed for myself and thought others might find it
useful, up to you if you want them there officially! :) I agree having them
commented out, or as part of some official documented examples may be
better for your graphing dependencies.

Thanks!
Chris.

On 18 June 2012 23:10, William Leibzon <
reply@reply.github.com

wrote:

Hi Chris,

I have not decided yet if I'm going to merge this into branch because it'd
require changing graph templates distributed with this plugin. I do agree
that some people will find these more useful than what is included. But the
plugin is written as an example so that adding new expressions like you did
for those who need is easy since they are just one-liner definitions. So
these are really more like examples of config customizations than a plugin
code. One possibility is simply including yours in the plugin but having
them commented out and those who need it would un-comment. I'll think about
it more and test if adding these would break graphing or not. I do thank
you for your willingness contribute.

Regards,

William


Reply to this email directly or view it on GitHub:
willixix/WL-NagiosPlugins#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants