fix(release): pass --repo to gh release upload + bump rand to 0.9.4#50
Merged
fix(release): pass --repo to gh release upload + bump rand to 0.9.4#50
Conversation
The v0.4.0 re-release hit a second failure in the same workflow: the
`Upload SBOM to GitHub Release` and `Upload SHA256SUMS to GitHub Release`
steps both errored with:
failed to run git: fatal: not a git repository
(or any of the parent directories): .git
The `publish` job has no `actions/checkout` step, so `gh release upload`
cannot infer the target repository from `.git/config` and bails out
before the API call.
Pass the repo explicitly via `--repo "${{ github.repository }}"` on both
upload steps so they work without a checkout.
Context: the v0.4.0 wheels and sdist DID make it to PyPI (the publish
step itself succeeded). Only the GitHub Release asset uploads failed,
which is why the 0.4.0 release page has empty assets. Leaving v0.4.0
as-is; this fix takes effect for the next tagged release.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Closes Dependabot alert #6. Versions < 0.9.3 are unsound when used with a custom `log` logger that calls `rand::rng()` and hits a reseed during the log call. We don't trigger that path (we use `rand_chacha::ChaCha8Rng` directly, no custom logger, no `log` feature), so the bug is not reachable in forgery — but this is a free lockfile-only fix and the current version was flagged on the repo. `Cargo.toml` pin (`rand = "0.9"`) unchanged; `cargo update -p rand` pulls 0.9.4 under that constraint. All 832 Rust tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
williajm
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes bundled into one small PR:
1. Release workflow:
gh release uploadneeds--repoSecond failure on the v0.4.0 re-release: the two `gh release upload` steps errored with `fatal: not a git repository`. The publish job has no `actions/checkout`, so `gh` can't infer the target repo. Pass `--repo "${{ github.repository }}"` explicitly to both steps.
2. Bump `rand` 0.9.2 → 0.9.4 (closes Dependabot alert #6, GHSA-cq8v-f236-94qc)
`rand` < 0.9.3 is unsound when used with a custom `log` logger that calls `rand::rng()` and hits a reseed during the log call. We don't trigger that path (we use `rand_chacha::ChaCha8Rng` directly, no custom logger, no `log` feature), so the bug is not reachable in forgery — but this is a free lockfile-only fix and the alert was open on the repo.
`Cargo.toml` pin (`rand = "0.9"`) unchanged; `cargo update -p rand` pulls 0.9.4 under that constraint.
Context on v0.4.0
Test plan
🤖 Generated with Claude Code