Skip to content

[ELY-2863] Add X509 client credential support#2239

Open
timhamoni wants to merge 2 commits intowildfly-security:2.xfrom
timhamoni:oidc-x509certauth
Open

[ELY-2863] Add X509 client credential support#2239
timhamoni wants to merge 2 commits intowildfly-security:2.xfrom
timhamoni:oidc-x509certauth

Conversation

@timhamoni
Copy link
Copy Markdown

This is a fix to add support for X509 client certificate credentials.

https://issues.redhat.com/browse/ELY-2863?filter=-2

public void init(OidcClientConfiguration oidcClientConfiguration,
Object credentialsConfig) {
// Not possible to check the key/truststore configuration from here. It needs access to the
// OidcJsonConfiguration object to check.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @timhamoni , very sorry for late review. Just a question - the OidcJsonConfiguration object does not carry information about key/truststore which the OIDC client should use though. You can only configure ssl-required with values "all", "none" or "external" in the OidcJsonConfiguration. Are you configuring the SSLContext in the code in the secure-deployment, or some other way?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, that's correct. However, the OidcJsonConfiguration does carry information about the trust store and client key store. I put the comment as a note, so that users of the Provider should not expect any confirmation of the configuration correctness during the init. For this to work, I configured the client ssl context in WildFly with the correct key/trust store. After that, the provider added the client identifier to the request which was the magic to make it all work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants