This repository was archived by the owner on Jun 25, 2018. It is now read-only.
Proper and Stable Gaming system#1
Open
valid22 wants to merge 11 commits into
Open
Conversation
| use Handlers\Game\Multiplayer; | ||
| use Handlers\Game\Waddle; | ||
| use Handlers\Game\Games; | ||
| use Handlers\Game\Four; |
Owner
There was a problem hiding this comment.
Should probably move all implementation related code to it's own folder/namespace (Game\FindFour\xxx).
Owner
|
Make sure you finish off your TODO list. I'll wait to merge until then. |
| use Kitsune\ClubPenguin\Handlers\Game\FindFour; | ||
|
|
||
| trait Four | ||
| { |
Owner
There was a problem hiding this comment.
Make your brackets consistent with the rest of the codebase. Keep them on the same line as whatever language construct you're declaring (classes, functions, etc).
Author
|
Yeah, I'll possibly try doing Todos very soon. |
|
Was this ever finished? |
Author
|
@rushilsrivastava It's a game system. It supports all single player games, and implemented Mancala, FindFour and Sled Racing atm. This gaming system is made so that you could easily implemenet games, without chaos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've pulled my own stable game system and also corrected game-room identification in world
TO-DO : Generalize Table games (Yet only 2 are there and they are done :P )