Open
Conversation
…for each conversion? I am but a todler trying to operate a spaceship.
Member
Author
|
I think I did it but in the process created scary warnings above my paygrade: |
…for each conversion? I am but a todler trying to operate a spaceship.
…for each conversion? I am but a todler trying to operate a spaceship.
Member
Author
|
Fixed all the checkstyle stuff but it doesn't recognize it. Leaving it here for Jack to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick fix to allow for differing levels for precision in results. Conversions now use a fixed 3 point precision, base numbers use whatever variable is assigned in the config. The reason is that we had too many kids misread the "." and mistake it for a "," and write things like "the gravity is 1000 times that of earth", when it was being expressed as "1.000 times" - I've reworded some of the science tools to match how kids can more logically interpret them: pressure, gravity and radiation are now all "%" of what they would be on earth as the default measure, with specific units that they don't really understand written in the parenthesis in high-precision. So Mars has "38% of earth's gravity" but that's then expressed as 3.727 m/s^2.
A smarter way to do this would be to have a config option for either separate precision for each conversion OR a T/F option for a given science tool to be expressed as percentage. That said my change could be done altering 2 characters in just two files and didn't break anything so I'm going with it for now. Jack I understand if you don't want to merge this and want to do it the right way. I'll make another attempt on this branch for you to review if I can.