Conversation
Adding region-members to region database table Incrementing version number
jackah2
approved these changes
Apr 16, 2025
Member
jackah2
left a comment
jackah2
left a comment
There was a problem hiding this comment.
Looks great, thanks! If you tested locally and everything is working fine I say merge it :)
Comment on lines
+37
to
+42
| /* Defensive null check */ | ||
| if (getCommand("positiontracker") != null) { | ||
| getCommand("positiontracker").setExecutor(new TrackerCommand(this)); | ||
| } else { | ||
| getLogger().warning("Command 'positiontracker' is not defined in plugin.yml!"); | ||
| } |
Member
There was a problem hiding this comment.
Honestly this isn't necessary but not worth removing it
Comment on lines
+10
to
+22
| // Add to whimc_player_positions | ||
| private static final String ADD_POS_YAW = | ||
| "ALTER TABLE whimc_player_positions ADD COLUMN yaw FLOAT AFTER z;"; | ||
| private static final String ADD_POS_PITCH = | ||
| "ALTER TABLE whimc_player_positions ADD COLUMN pitch FLOAT AFTER yaw;"; | ||
|
|
||
| // Add to whimc_player_region_events | ||
| private static final String ADD_REGION_YAW = | ||
| "ALTER TABLE whimc_player_region_events ADD COLUMN yaw FLOAT AFTER z;"; | ||
| private static final String ADD_REGION_PITCH = | ||
| "ALTER TABLE whimc_player_region_events ADD COLUMN pitch FLOAT AFTER yaw;"; | ||
| private static final String ADD_REGION_MEMBERS = | ||
| "ALTER TABLE whimc_player_region_events ADD COLUMN region-members VARCHAR(64) AFTER region;"; |
Member
There was a problem hiding this comment.
I believe these the queries can be combined into 1 per table. But also probably not worth making that change - this is very clear as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new schema for DB, more items collected to be used for triggers.