Refactor scheduler and base queue to use Abseil primitives#183
Draft
Refactor scheduler and base queue to use Abseil primitives#183
Conversation
- Replace std::unordered_map with absl::flat_hash_map in scheduler headers - Replace std::mutex with absl::Mutex in scheduler and thread_safe_queue - Use absl::WriterMutexLock for exclusive lock guards - Replace std::condition_variable with absl::Mutex::Await() in ThreadSafeQueue - Replace string .append() chains with absl::StrAppend() in scheduler - Use absl::StrCat for string construction in scheduler_factory - Add ABSL_GUARDED_BY annotations for thread safety documentation - Update BUILD files with absl dependencies - Update scheduler test to use absl::flat_hash_map Co-authored-by: daohu527 <10419854+daohu527@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Apollo C++ code to use Abseil and Folly for performance
Refactor scheduler and base queue to use Abseil primitives
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces STL synchronization and container primitives in the cyber scheduler and base queue with Abseil equivalents for improved cache efficiency, richer thread-safety annotations, and cleaner async patterns.
Changes
cyber/base/thread_safe_queue.hstd::mutex+std::condition_variable→absl::Mutex+absl::MutexLock+Await()volatile bool break_all_wait_→boolwithABSL_GUARDED_BY(mutex_)annotationIsReadyForDequeue()condition predicate forAwait()cyber/scheduler/scheduler.h+ policy headersstd::unordered_map→absl::flat_hash_map(Swiss table; better cache locality)std::mutex cr_wl_mtx_→absl::Mutexcyber/scheduler/scheduler*.ccstd::lock_guard<std::mutex>oncr_wl_mtx_→absl::WriterMutexLock.append()chains →absl::StrAppend()/absl::StrCat()scheduler_factory.cc:std::mutex→absl::MutexBuild
@com_google_absl//absl/container:flat_hash_map,absl/synchronization, andabsl/stringsdeps to affected targets.Example: WaitDequeue before/after
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.