feat: Layered configuration override support with /data/conf persistence#170
Draft
feat: Layered configuration override support with /data/conf persistence#170
Conversation
Co-authored-by: daohu527 <10419854+daohu527@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Apollo configuration management for layered overrides
feat: Layered configuration override support with /data/conf persistence
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config loading had no override mechanism — changing defaults required modifying source files or using symlinks that polluted the tree. There was also no path toward Parameter Server integration.
Changes
New:
cyber/common/config_loader.h/ccIntroduces
GetProtoFromFileWithOverride()— a drop-in replacement forGetProtoFromFile()that applies a two-tier load strategy:/data/conf/<basename>and deep-merged viaproto::Message::MergeFrom()(only explicitly-set fields in the override win)Override files are partial — only fields you want to change need to be present:
Reference adoption:
modules/control/control_component.ccMigrated to
GetProtoFromFileWithOverrideas the canonical example for other modules to follow.Build:
cyber/common/BUILDAdded
config_loadercc_library andconfig_loader_testtargets.Tests:
cyber/common/config_loader_test.ccCovers: default-only load, missing-file failure, and merge semantics (overridden fields win, unset fields retain defaults).
Docs
docs/configuration_override.md— override priority design, merge semantics, security guidelines, migration instructionsdocs/configuration_inventory.md— full inventory of config loading points across all modules with migration statusOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.