feat: change openspace in stage_approaching_parking_spot#165
Open
feat: change openspace in stage_approaching_parking_spot#165
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts the valet parking “approach/setup” phase away from reference-line (lane-follow) planning and toward Open Space planning, using the parking-space-id to fetch the target spot from HDMap and using a (routing/map-derived) parking-spot center for proximity checks.
Changes:
- Routing: add validation/fallback so parking corner points can be supplemented from HDMap when missing in routing request.
- Planning: update OpenSpace ROI / pre-stop / valet scenario logic to fetch target parking spot by id and use a parking-spot center (routing-first, map-fallback) for distance gating.
- Scenario/config: switch VALET_PARKING_APPROACHING_PARKING_SPOT stage tasks to Open Space task chain and update approaching stage to execute Open Space tasks.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/routing/routing.cc | Adds parking_space_id guard and HDMap-based fallback for missing parking corner points during supplement. |
| modules/planning/tasks/deciders/open_space_decider/open_space_roi_decider.h | Updates APIs to fetch target parking spot by id and simplifies distance-check signature. |
| modules/planning/tasks/deciders/open_space_decider/open_space_roi_decider.cc | Implements HDMap id lookup for parking spot and Euclidean distance gating using routing/map-derived center. |
| modules/planning/tasks/deciders/open_space_decider/open_space_pre_stop_decider.cc | Computes pre-stop target s from parking-spot center projected onto reference line (routing/map fallback). |
| modules/planning/scenarios/park/valet_parking/valet_parking_scenario.h | Replaces “search on path” helper with HDMap id lookup and updates distance-check API. |
| modules/planning/scenarios/park/valet_parking/valet_parking_scenario.cc | Uses HDMap id lookup + Euclidean distance check for scenario transferability. |
| modules/planning/scenarios/park/valet_parking/stage_approaching_parking_spot.cc | Switches approaching stage execution to Open Space tasks and uses ParkAndGo status for setup-pose completion checks. |
| modules/planning/conf/scenario/valet_parking_config.pb.txt | Replaces reference-line task list in approaching stage with Open Space task chain (ROI/trajectory/fallback). |
modules/planning/scenarios/park/valet_parking/stage_approaching_parking_spot.cc
Outdated
Show resolved
Hide resolved
modules/planning/tasks/deciders/open_space_decider/open_space_pre_stop_decider.cc
Outdated
Show resolved
Hide resolved
modules/planning/tasks/deciders/open_space_decider/open_space_pre_stop_decider.cc
Outdated
Show resolved
Hide resolved
modules/planning/tasks/deciders/open_space_decider/open_space_roi_decider.cc
Outdated
Show resolved
Hide resolved
modules/planning/tasks/deciders/open_space_decider/open_space_roi_decider.cc
Show resolved
Hide resolved
modules/planning/scenarios/park/valet_parking/valet_parking_scenario.cc
Outdated
Show resolved
Hide resolved
f7d0c69 to
607fbd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parking Planning Phases
Phase 1 — Cruising / Searching
Phase 2 — Approach / Setup
Phase 3 — Maneuver / Docking