Open
Conversation
595eab2 to
e778bb3
Compare
The PER-CS2.0 ruleset of Symfony doesn't match the documentation. We choose the more readable version, which is also part of the official PER-CS2.0 ruleset (https://cs.symfony.com/doc/ruleSets/PER-CS2.0.html) #15
… standards as well
4413f3c to
8666429
Compare
Contributor
|
the SymfonySet defines https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/RuleSet/Sets/SymfonySet.php#L206 our ECS config enforces it |
Contributor
|
Same issuse https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/RuleSet/Sets/SymfonySet.php#L219 our ECS enforces for 'arguments' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we go. I went through all the issues we had. Solved them and cleaned up more issues.
Since we're adding PER Coding Style 2.0 (https://www.php-fig.org/per/coding-style/), it's a major release.
I ran it on a local project, and I could auto-fix all changes. The following rules had to be changed:
The updates @rugbymauri is working on with CS Fixer aren't ready yet, and I created a milestone for those adjustments. Once this is ready, we see if there's another major needed or if it's backwards compatible. For now, I want to release those adjustments to have a clean base again.