Open
Conversation
tuxes3
reviewed
May 23, 2024
Member
tuxes3
left a comment
tuxes3
left a comment
There was a problem hiding this comment.
what effective change are being made with this dynamic Set?
Member
|
@tuxes3 The code has to be fixed and reviewed after an upgrade. Things like "Alphabetical Order of Import Statements", "Explicit Visibility for Properties and Methods" or "Encouragement of Type Hints and Return Types" are new in the standards. "Spaces Around Concatenation Operator" is something we enforced already in contrast to the Symfony guidelines (if I'm informed correctly), which is now a part of the standards. I would hold this back for now until we did the refactoring for v2 and then rollout the new standards with it. That's more smooth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19