Add invalid character test for is_possible_3wa#19
Open
Jonty wants to merge 1 commit intowhat3words:masterfrom
Open
Add invalid character test for is_possible_3wa#19Jonty wants to merge 1 commit intowhat3words:masterfrom
is_possible_3wa#19Jonty wants to merge 1 commit intowhat3words:masterfrom
Conversation
`is_possible_3wa` currently excludes invalid characters, but this is an incomplete list and many invalid characters can still be accepted as a "possible" w3w address.
Contributor
|
hi @Jonty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_possible_3wacurrently excludes invalid characters, but this is an incomplete list and many invalid characters can still be accepted as a "possible" w3w address.This PR adds a failing test for this case, but does not fix the issue as the regex is very hard to understand and I think it's better that someone familiar with the original intent attempts to fix it properly.
This is also a problem with
find_possible_3waanddid_you_mean.