Feature: Add BMI Tile to Dashboard & BMI Calculation #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandgeider
reviewed
Dec 4, 2025
lib/models/user/profile.dart
Outdated
| this.weight, | ||
| }); | ||
| double calculateBmi({double? weightOverride}) { | ||
| // 1. Wir definieren, welches Gewicht wir nutzen (Override ODER Profil) |
Member
There was a problem hiding this comment.
Kommentare auf Englisch bitte :)
Contributor
Author
There was a problem hiding this comment.
Okay, I did it. I hope it worked with the upload. I'm not really familiar with l10n yet.
Contributor
Author
There was a problem hiding this comment.
I've pushed another update based on testing:
- New UI Layout: Moved the current BMI stats below the chart. This gives the chart full width and prevents date labels from being cut off.
- Interactive Tooltip: Tapping a point on the chart now shows the exact BMI value and date in a tooltip.
- Dynamic Date Axis: The x-axis now smartly formats dates:
- Default:
dd.MM(e.g. 12.03) - If range > 365 days:
MM/yy(e.g. 03/25) to save space.
- Default:
The widget should now look consistent and be fully responsive.
Contributor
Author
There was a problem hiding this comment.
The settings_test.dart is failing because the mocks for SharedPreferences don't know about the new key 'show_bmi_dashboard' yet. Since I cannot easily regenerate the mocks without modifying the build setup, could you please advise or update the test mocks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Profilemodel (fallback to 0 if weight/height missing).DashboardBmiWidget: A new tile displaying current BMI, category, and history chart.UserProviderto toggle the BMI tile visibility on the dashboard.DashboardScreen.DashboardWeightWidget(removed redundant switch).Related Issue(s)# Proposed Changes
Profilemodel (fallback to 0 if weight/height missing).DashboardBmiWidget: A new tile displaying current BMI, category, and history chart.UserProviderto toggle the BMI tile visibility on the dashboard.DashboardScreen.DashboardWeightWidget(removed redundant switch).Related Issue(s)
Closes #2132
Please check that the PR fulfills these requirements
///).Closes #2132
Please check that the PR fulfills these requirements
///).