Skip to content

Ignore silent option for anvil instances #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisx9z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore silent option for anvil instances #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/instances/anvil.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Instance } from 'prool'
import { afterEach, expect, test } from 'vitest'

import { anvil } from './anvil.js'

const instances: Instance.Instance[] = []
const timestamp = 1717114065

Expand Down Expand Up @@ -40,6 +42,14 @@ test('default', async () => {
expect(instance.messages.get()).toMatchInlineSnapshot('[]')
})

test('behavior: ignores silent option', () => {
const instance = anvil({
silent: true,
} as anvil.Parameters & { silent: boolean })

expect(instance._internal.args).not.toHaveProperty('silent')
})

test('behavior: instance errored (duplicate ports)', async () => {
const instance_1 = defineInstance({ timestamp, port: 8545 })
const instance_2 = defineInstance({ timestamp, port: 8545 })
Expand Down
10 changes: 5 additions & 5 deletions src/instances/anvil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ import { execa } from '../processes/execa.js'
* ```
*/
export const anvil = Instance.define((parameters?: anvil.Parameters) => {
const { binary = 'anvil', ...args } = parameters || {}
const {
binary = 'anvil',
silent: _silent,
...args
} = (parameters as anvil.Parameters & { silent?: boolean }) || {}

const name = 'anvil'
const process = execa({ name })
Expand Down Expand Up @@ -267,10 +271,6 @@ export declare namespace anvil {
* @defaultValue 5
*/
retries?: number | undefined
/**
* Don't print anything on startup and don't print logs.
*/
silent?: boolean | undefined
/**
* Slots in an epoch.
*/
Expand Down