Skip to content

feat: make testcontainer tempo startup timeout configurable#68

Closed
brendanjryan wants to merge 3 commits into
wevm:mainfrom
brendanjryan:fix/testcontainers-tempo-startup-timeout
Closed

feat: make testcontainer tempo startup timeout configurable#68
brendanjryan wants to merge 3 commits into
wevm:mainfrom
brendanjryan:fix/testcontainers-tempo-startup-timeout

Conversation

@brendanjryan

@brendanjryan brendanjryan commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a startupTimeout option to testcontainers.Instance.tempo so callers can tune readiness in slower environments
  • introduce a shared internal container-options module for testcontainers-backed instances, so future container adapters can reuse the same option pattern
  • keep the default startup timeout unchanged at 10_000ms
  • harden tests for fork PRs by avoiding empty VITE_FORK_URL values and giving slow-start tempo integration tests explicit time budgets
  • include a patch changeset entry for release notes

Validation

  • pnpm check
  • pnpm check:types
  • pnpm exec vitest run src/testcontainers/Instance.test.ts --testTimeout=120000

@pkg-pr-new

pkg-pr-new Bot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/prool@68

commit: 8423134

@brendanjryan brendanjryan force-pushed the fix/testcontainers-tempo-startup-timeout branch from d040c0f to 6e140aa Compare March 24, 2026 15:27
@brendanjryan brendanjryan force-pushed the fix/testcontainers-tempo-startup-timeout branch from 6e140aa to ce43834 Compare March 24, 2026 15:33
@brendanjryan

Copy link
Copy Markdown
Contributor Author

Superseded by a clean PR with only the startup timeout changes (no unrelated CI/test modifications).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant