Skip to content

test(tempo): cover access key authorizations#483

Merged
deodad merged 2 commits into
mainfrom
dad/test-access-key-authorizations
May 28, 2026
Merged

test(tempo): cover access key authorizations#483
deodad merged 2 commits into
mainfrom
dad/test-access-key-authorizations

Conversation

@deodad
Copy link
Copy Markdown
Contributor

@deodad deodad commented May 28, 2026

Summary

Bump viem + Add test coverage for all MPP payment paths that tests that access key accounts using a key authorization manager will attach the key authorization on the first transaction.

Motivation

Previously access keys accounts could only be used if previously registered onchain. The latest version of viem allows access key accounts to attach an authorization manager that viem will use to attach authorization during prepareTransactionRequest.

Changes

  • Updated viem to 2.51.3 in package.json and pnpm-workspace.yaml which had a fix for failing getMetadata calls when sent from an unauthorized access key account
  • Added src/tempo/AccessKeyAuthorization.test.ts for charge pull, charge push fallback, session open, session settle, and session close.
  • Asserted generated Tempo transactions include the pending keyAuthorization from KeyAuthorizationManager.

Testing

  • CI=true ./node_modules/.bin/vp test src/tempo/AccessKeyAuthorization.test.ts
  • CI=true pnpm check:types
  • CI=true pnpm check

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 28, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedviem@​2.51.310010010098100

View full report

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 28, 2026

Open in StackBlitz

npm i https://pkg.pr.new/mppx@483

commit: 652db5d

@deodad deodad marked this pull request as ready for review May 28, 2026 01:09
@deodad deodad merged commit 58f7efd into main May 28, 2026
11 checks passed
@deodad deodad deleted the dad/test-access-key-authorizations branch May 28, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants