fix: reject unknown properties on session() and charge() at compile time#203
Open
brendanjryan wants to merge 1 commit intomainfrom
Open
fix: reject unknown properties on session() and charge() at compile time#203brendanjryan wants to merge 1 commit intomainfrom
brendanjryan wants to merge 1 commit intomainfrom
Conversation
commit: |
43fe4b7 to
ba24a01
Compare
Add NoExtraKeys utility type and apply it via overload signatures to
tempo.session() and tempo.charge(). This catches typos like
`stream: { poll: true }` instead of `sse: { poll: true }` that
previously slipped through because generic `extends` constraints
bypass excess property checking.
Fixes the class of bug from PR #159.
ba24a01 to
cb52419
Compare
brendanjryan
commented
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Makes interface for kwargs on mppx core types safer
Solution
Add a
NoExtraKeys<T, Shape>utility type that maps any key inTnot present inShapetonever, and apply it tosession()andcharge()via overload signatures.