Conversation
…ckend selection - Enhance `LaunchVerification` with Windows user and path diagnostics - Implement dynamic Windows username detection in `check_prefix_health` - Add verification for Steam client and PhysX middleware in the prefix - Capture first 50 and last 100 lines of Wine log for early exit analysis - Expand `classify_graphics_evidence` to detect middleware and bootstrap failures - Include `STEAM_COMPAT_APP_ID` in launch environment - Update concise launch summary with new diagnostic fields Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Modify `build_dll_overrides` to exclude `d3d10` and `d3d10_1` from explicit DXVK overrides, allowing Wine's built-in wrappers to delegate to `d3d10core` natively. - Add `DANGEROUS_ALIAS_OVERRIDE` validation to `LaunchInvariantValidator` to warn against explicit native overrides for alias DLLs. - Enhance `classify_early_exit` and `classify_graphics_evidence` with new regression categories: `startup_environment_regression`, `override_policy_regression`, and `steam_runtime_exposure_regression`. - Improve tracing logs in `WineTkgRunner` to record override generation and alias skipping. - Ensure `STEAM_COMPAT_APP_ID` is included in the launch environment. - Implement dynamic Windows username detection and middleware/client path verification in prefix health checks. - Capture first 50 and last 100 lines of Wine log for early exit analysis. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
- Remove `d3d10` and `d3d10_1` from `DllProviderResolver` target list. - Clean up `ResolveDllProvidersStage` to remove DXVK capability fixup for aliases. - Audit `utils.rs` and remove aliases from `build_dll_overrides` and `cleanup_dll_symlinks`. - Update `LaunchInvariantValidator` and `OverrideConflictValidator` to remove alias-specific rules. - Refine error classification patterns in `pipeline.rs` and `wine_capture.rs`. - Focus diagnostics and launch configuration entirely on concrete DXVK DLLs (`d3d8`, `d3d9`, `d3d10core`, `d3d11`, `dxgi`). Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
- Implement `StartupMilestone` detection to track launch phases. - Add dependency family detection (PhysX vs SDL2) to identify title-specific ecosystems. - Remove `d3d10` and `d3d10_1` from runtime configuration and overrides. - Capture 'Head' and 'Tail' of Wine logs for diagnostic context. - Update launch summaries with milestone and dependency metadata. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances SteamFlow's diagnostic capabilities to investigate early startup failures that occur before the graphics renderer initializes, specifically targeting issues observed with Batman: Arkham Origins.
Key improvements:
drive_c/usersdirectory to identify the active Windows user, allowing for correct path verification instead of assumingsteamuser.PhysXLoader.dllandsteam.exewithin the prefix.steam_environment_incompleteandmiddleware_dependency_failure.STEAM_COMPAT_APP_IDto the environment to better match Proton's expectations.These changes provide the evidence needed to distinguish between graphics backend issues and bootstrap/dependency failures.
PR created automatically by Jules for task 15818427056771741611 started by @weter11