Conversation
Introduces a post-spawn verification window to detect game processes that exit immediately or fail to initialize correctly. Key changes: - Added `LaunchResult::Uncertain` and `LaunchVerification` diagnostics. - Implemented a 2-second verification window in `LaunchPipeline`. - Tracked log growth and graphics evidence to detect healthy vs uncertain launches. - Added detailed warnings for `LAUNCH_EARLY_EXIT` and `LAUNCH_UNCERTAIN`. - Included comprehensive tests for verification scenarios. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added a per-game NVAPI toggle to Graphics Settings. - Improved runtime evidence collection to detect successful DXVK initialization. - Implemented granular early-exit classification (e.g., "DXVK loaded but game exited early"). - Added prefix health checks to verify WINEPREFIX and user directories. - Filtered non-fatal Wine warnings (winemac.drv) from strict graphics failure reports. - Enhanced concise launch summaries with prefix and NVAPI metadata. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
Treats D3D10 and D3D10.1 as capabilities satisfied by d3d10core, d3d11, and dxgi when using the DXVK backend, rather than requiring literal standalone DLL files. Key changes: - Introduced `DllProvider::Internal` for capability-satisfied DLLs. - Implemented DXVK capability fixup in `ResolveDllProvidersStage`. - Updated `build_dll_overrides` to allow builtin fallback for d3d10/d3d10_1. - Improved validation error messages for missing D3D10 capabilities. - Fixed launch result prioritization for degraded but failed launches. Co-authored-by: weter11 <14630689+weter11@users.noreply.github.com>
1 participant
This PR addresses an issue where
SteamFlowwould report a "Success" result even if the game process (Wine) exited immediately after spawning.Changes include:
Failurewith afailed_after_spawnstatus.Uncertain.summary.jsonand the event log now include detailed verification metadata, such as process lifetime, exit code, and log growth observations.LaunchInvariantValidatornow emits specific warnings (LAUNCH_EARLY_EXIT,LAUNCH_UNCERTAIN) to help users troubleshoot these cases.PR created automatically by Jules for task 17618267327832553973 started by @weter11