GC Combo-box component (WET-631)#2719
Open
BrahimMahadi wants to merge 1 commit intowet-boew:masterfrom
Open
Conversation
b8c87c8 to
0bbc112
Compare
0bbc112 to
55e62e1
Compare
55e62e1 to
678329e
Compare
678329e to
9760a0b
Compare
9760a0b to
64f5d42
Compare
64f5d42 to
e564f03
Compare
Garneauma
requested changes
Apr 7, 2026
Collaborator
Garneauma
left a comment
There was a problem hiding this comment.
This is just a quick partial review.
duboisp
requested changes
Apr 15, 2026
Member
duboisp
left a comment
There was a problem hiding this comment.
A few comment after your presentation.
- Use/allow the slot for label
- Use named slot for options instead of JSON array in an attribute
- Use series of hidden input for an integration into form API
- Use "is" ex: . (But this will require functional + compatibility testing in safari + safari mobile)
- Allow an option where we manually add my own custom tag. vs using datalist (for more info, check the HTML5 specification around it)
- Allow the customization of colour used for tags (background+colour) by using the
partattribute
Authoring code sample example
<label for="mycbx">Label</label>
<input id="mycbx" is="combo-box-component" multiple name="cbx" list="function-types">
<datalist id="function-types">
<option value="function">function</option>
<option value="async function">async function</option>
<option value="function*">generator function</option>
<option value="=>">arrow function</option>
<option value="async =>">async arrow function</option>
<option value="async function*">async generator function</option>
</datalist>
Or alternatively
<combo-box-component
id="demo"
placeholder="Select technologies...">
<div slot="label">Select<sup>sup</sup> Technologies label</div>
<datalist slot="options">
<option>JavaScript</option>
<option>TypeScript</option>
<option>React</option>
<option>Vue</option>
<option>Angular</option>
<option>Node.js</option>
</datalist>
</combo-box-component>
Other ref.
- https://html.spec.whatwg.org/multipage/input.html#attr-input-multiple
- https://html.spec.whatwg.org/multipage/input.html#attr-input-list
And regardless of my above comment, we know that eventually this component, after our immediate need satisfied, we are going to transform / re-code it as a GCDS component, so feel free to take decision that will be aligned with how GCDS component will be develop.
4f06d45 to
4ee990d
Compare
4ee990d to
5268d76
Compare
5268d76 to
e4a5633
Compare
e4a5633 to
5981f3e
Compare
5981f3e to
d47a49d
Compare
d47a49d to
2800019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An accessible combo-box component that provides a modern, user-friendly interface for selecting multiple items. Reference JIRA ticket WET-631.