Skip to content

fix: convert dataset values to numbers in async typer #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vedant43hh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: convert dataset values to numbers in async typer #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions exercises/73 - Async Typer/scripts-FINISHED.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,14 @@ function getRandomBetween(min = 20, max = 150, randomNumber = Math.random()) {
return Math.floor(randomNumber * (max - min) + min);
}

// async for of loop
// async function draw(el) {
// const text = el.textContent;
// let soFar = '';
// for (const letter of text) {
// soFar += letter;
// el.textContent = soFar;
// // wait for some amount of time
// const { typeMin, typeMax } = el.dataset;
// const amountOfTimeToWait = getRandomBetween(typeMin, typeMax);
// await wait(amountOfTimeToWait);
// }
// }


// recursion
function draw(el) {
let index = 1;
const text = el.textContent;
const { typeMin, typeMax } = el.dataset;
const typeMin = parseInt(el.dataset.typeMin, 10);
const typeMax = parseInt(el.dataset.typeMax, 10);
async function drawLetter() {
el.textContent = text.slice(0, index);
index += 1;
Expand Down