Skip to content

fix: goroutine leak in watch error channel consumer for ReleaseUninstall #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmmordvi merged 2 commits into from
Mar 27, 2026
+27 −6
Merged

fix: goroutine leak in watch error channel consumer for ReleaseUninstall #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6af1a5
fix: goroutine leak in watch error channel consumer for ReleaseInstal…
dmmordvi Mar 25, 2026
ef25f1d
Merge branch 'main' into fix/watch-err-ch-goroutine-leak
dmmordvi Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/action/release_install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,15 @@ func releaseInstall(ctx context.Context, ctxCancelFn context.CancelCauseFunc, re
log.Default.Debug(ctx, "Start tracking")

go func() {
if err := <-watchErrCh; err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
for {
select {
case err := <-watchErrCh:
if err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
}
case <-ctx.Done():
return
}
}
}()

Expand Down
11 changes: 9 additions & 2 deletions pkg/action/release_rollback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,15 @@ func releaseRollback(ctx context.Context, ctxCancelFn context.CancelCauseFunc, r
log.Default.Debug(ctx, "Start tracking")

go func() {
if err := <-watchErrCh; err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
for {
select {
case err := <-watchErrCh:
if err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
}
case <-ctx.Done():
return
}
}
}()

Expand Down
11 changes: 9 additions & 2 deletions pkg/action/release_uninstall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,15 @@ func releaseUninstall(ctx context.Context, ctxCancelFn context.CancelCauseFunc,
informerFactory := informer.NewConcurrentInformerFactory(ctx.Done(), watchErrCh, clientFactory.Dynamic(), informer.ConcurrentInformerFactoryOptions{})

go func() {
if err := <-watchErrCh; err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
for {
select {
case err := <-watchErrCh:
if err != nil {
ctxCancelFn(fmt.Errorf("context canceled: watch error: %w", err))
}
case <-ctx.Done():
return
}
}
}()

Expand Down
Loading