Skip to content

feat(cli): add NoSplitOnCommas option to AddFlag() #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilya-lesikov merged 1 commit into from
Oct 17, 2025
Merged

feat(cli): add NoSplitOnCommas option to AddFlag() #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions pkg/cli/flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@ type AddFlagOptions struct {
// the --help output.
Group *FlagGroup

Type FlagType
ShortName string
Deprecated bool
Hidden bool
Required bool
Type FlagType
ShortName string
Deprecated bool
Hidden bool
Required bool
NoSplitOnCommas bool
}

// TODO(ilya-lesikov): allow restricted values
Expand Down Expand Up @@ -65,7 +66,7 @@ func AddFlag[T any](cmd *cobra.Command, dest *T, name string, defaultValue T, he
return fmt.Errorf("build help: %w", err)
}

if err := addFlags(cmd, dest, name, opts.ShortName, defaultValue, help); err != nil {
if err := addFlags(cmd, dest, name, opts.ShortName, defaultValue, opts.NoSplitOnCommas, help); err != nil {
return fmt.Errorf("add flags: %w", err)
}

Expand Down Expand Up @@ -147,7 +148,7 @@ func buildHelp[T any](help string, dest *T, envVarRegexes []*FlagRegexExpr) (str
return help, nil
}

func addFlags[T any](cmd *cobra.Command, dest *T, name string, shortName string, defaultValue T, help string) error {
func addFlags[T any](cmd *cobra.Command, dest *T, name string, shortName string, defaultValue T, noSplitOnCommas bool, help string) error {
switch dst := any(dest).(type) {
case *bool:
cmd.Flags().BoolVarP(dst, name, shortName, any(defaultValue).(bool), help)
Expand All @@ -156,7 +157,11 @@ func addFlags[T any](cmd *cobra.Command, dest *T, name string, shortName string,
case *string:
cmd.Flags().StringVarP(dst, name, shortName, any(defaultValue).(string), help)
case *[]string:
cmd.Flags().StringSliceVarP(dst, name, shortName, any(defaultValue).([]string), help)
if noSplitOnCommas {
cmd.Flags().StringArrayVarP(dst, name, shortName, any(defaultValue).([]string), help)
} else {
cmd.Flags().StringSliceVarP(dst, name, shortName, any(defaultValue).([]string), help)
}
case *map[string]string:
cmd.Flags().StringToStringVarP(dst, name, shortName, any(defaultValue).(map[string]string), help)
case *time.Duration:
Expand Down