feat: harden persistence paths against workspace escape#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F39 Report
Resumo executivo
F39-persistence-path-root-hardeningendureceruns_db_patheartifacts_dircontra escapes doworkspace_root.AppSettingse consumido pelos entrypoints de CLI, worker e dashboard, preservando o AIgnt-Synapse-Flow como a engine propria de pipeline do AIgnt OS.Escopo alterado
AppSettingspassa a exporruns_db_path_resolvedeartifacts_dir_resolvedcli/app.py,runtime/worker.pyecli/dashboard.pypassam a consumir apenas os paths resolvidosdoctorpassa a reprovar explicitamente configuracao de persistencia fora doworkspace_rootSPEC.md,NOTES.md,CHECKLIST.mde esteREPORT.mdforam adicionados para aF39Validacoes executadas
validate_spec_file(Path("features/F39-persistence-path-root-hardening/SPEC.md"))pytest tests/unit/test_config.py tests/integration/test_runs_submit_cli.py tests/integration/test_runs_cli.py tests/integration/test_doctor_cli.py -qruff check src/aignt_os/config.py src/aignt_os/cli/app.py src/aignt_os/runtime/worker.py src/aignt_os/cli/dashboard.py tests/unit/test_config.py tests/integration/test_runs_submit_cli.py tests/integration/test_runs_cli.py tests/integration/test_doctor_cli.pymypy src/aignt_os/config.py src/aignt_os/cli/app.py src/aignt_os/runtime/worker.py src/aignt_os/cli/dashboard.py./scripts/commit-check.sh --no-sync --skip-branch-validation --skip-docker --skip-security./scripts/security-gate.shReview de seguranca
workspace_rootruns_db_patheartifacts_dircomresolve_path_within_rootValueErroremEnvironment error:nos entrypoints de CLIAIGNT_OS_WORKSPACE_ROOTcoerente com os paths persistidosRiscos residuais
workspace_rootcoerente no ambiente; configuracoes divergentes agora falham cedo, mas a escolha do root continua responsabilidade operacional do chamador.Proximos passos
Status final da frente
READY_FOR_COMMIT