Remove ineffective PORT env from Dockerfile#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The runtime stage of
backend/DockerfilecontainedENV PORT=8000with comments claiming it prevents Railway from injectingPORT=8080. This is incorrect — Railway's runtime environment variable injection always overrides DockerfileENVdirectives, so the line had no effect and was actively misleading.Solution
Removed
ENV PORT=8000and its two associated comment lines from the runtime stage. The actual fix — settingPORT=8000as a Railway service variable — is already applied via config, so this change is purely a dead-code cleanup that eliminates future confusion.Changes
backend/DockerfileGenerated by Railway