Open
Conversation
Collaborator
|
This all looks reasonable enough to me. Some suggestions:
|
Collaborator
|
Thanks for the contribution! |
Collaborator
|
(I do like the "shrink towards printable" goal you mentioned in #52; that is something we can write a test for.) |
Contributor
Author
|
rebased out the accidentally commited |
75a524e to
515f8de
Compare
Contributor
Author
|
I reworked stuff a little and added tests. (They found issues of course 😃) Still need to have a short think of how to best test |
edc7c8a to
1c71cf2
Compare
Collaborator
|
Marked this as WIP. Feel free to ping me when you think this is ready for review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my fumbling at #52 I added this to my project and thought if might be something you'd want to include.
The code points are taken from Hedgehog. I did consider adjusting the weights of
unicodeto skew more towards printable characters, but theres a lot of codepoints in unicde and I thought it's better to have hex escape codes than being biased too much towards ascii or sth.I'm not sure what an appropriate level of testing for code like this would be. I'd be happy to add some, but I think I need a little guidance on what to test.
This PR builds on #54 , if you're interested in merging this one but are concerned about
chooseAny, let me know and I'll remove the dependency