Add /var and /root free space checks to weka_upgrade_checker#575
Open
manmeet-weka wants to merge 2 commits into
Open
Add /var and /root free space checks to weka_upgrade_checker#575manmeet-weka wants to merge 2 commits into
manmeet-weka wants to merge 2 commits into
Conversation
Mirrors the existing logs partition check (warn if < 20% free). Motivated by WEKAPP-627335 where /var at 100% on SMBW nodes caused drive build failures and blocked upgrade. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
There are a couple of minimal changes that need to accompany every upgrade checker PR:
Please make these changes and I will continue with a review. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Done — bumped version to 1.12.2 in both version.txt and pg_version, and updated the compiled binary from 172.29.5.93. |
vrragosta
requested changes
Jun 9, 2026
| INFO("CHECKING /root DIRECTORY SPACE USAGE ON BACKENDS") | ||
| results = parallel_execution( | ||
| ssh_bk_hosts, | ||
| ["df -m /root | awk 'NR==2 {print $3, $4}'"], |
Contributor
There was a problem hiding this comment.
I think you want to check the actual root, no? df -m /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/varand/rootpartitions across all backend hostsfree_space_check_path()to avoid duplicating the log-space check logicTest plan
/varand/root🤖 Generated with Claude Code