Open
Conversation
New changes: 77f6ef000 Add/update a few JSDoc comments f44f08201 ve.dm.LinearData: Remove commented code 8171e96ff Converter: Separate Dom->Model and Model->Dom conversion into separate classes 1e0c83ecb Separate DomFromModel/ModelFromDomConverters into own files b70adb9a1 Document structure of LinearData 8084da9dd Merge (Element/Flat/-)LinearData 6b7c8fc6e Merge (Element/Flat/-)LinearData files 48e324bac LinearData: Remove getUsedStoreValues 1861cd357 LinearData: Remove containsElementData 14515e73d ve.dm.Model: Move this.store to ve.dm.Annotation a30515b4c ve.dm.Model: Remove store argument from getOriginalDomElements Added files: - src/dm/converters/ve.dm.DomFromModelConverter.js - src/dm/converters/ve.dm.ModelFromDomConverter.js Deleted files: - src/dm/lineardata/ve.dm.ElementLinearData.js - src/dm/lineardata/ve.dm.FlatLinearData.js - tests/dm/lineardata/ve.dm.ElementLinearData.test.js - tests/dm/lineardata/ve.dm.FlatLinearData.test.js Bug: T398975 Change-Id: I794b73a3b1c132c7b6ba4cd441fa284d30b336ee
Replaces the inconsistently named editSource, and introduces the functionality that checks if the document has been modified, rather than relying on the caller. Bug: T399223 Change-Id: Ic9a413aa0100c637652e3650cec041c651dc386a
…load For some reason, some hooks (e.g. ve.activationComplete) are fired in the Target class's code while others (e.g. ve.wikitextInteractive) are fired in the first-activation script (ve.init.mw.DesktopArticleTarget.init.js). I would've placed this change in the former location if not for the latter. I suspect there to be a design reason behind the latter's existence, so I chose to implement this change without touching the latter. Bug: T397778 Change-Id: If1a0faf60a7e12d22600b1d7372b76654ce8b072
This reverts commit aa9985f. Reason for revert: Temporary hack which is now fixed upstream. Change-Id: I7d65822a89487f86d237bccf3878bd77be721ae3
In WebdriverIO v9, skipped tests are reported as failed in JUnit reporter. The Jenkins jobs that runs tests daily fails because of it. Create a separate test suite for the daily job, so no tests are skipped there. Bug: T398310 Change-Id: I513f576376ad0eadf637d8f22e5a5c855cd61431
Change-Id: I9a3a710d88d6e1a62f15c66207aa797505430e80
…nerated Bug: T380432 Change-Id: I4718e2a938f70621f39e0aef89d1318596d51e61
Change-Id: I45b05fbf4583a2e87a560ce4e96eb72b64d52b63
768e73a replaced trackActivateStart()'s null-checking with a default parameter, but that doesn't account for the parameter being null. See relevant docs: defaulted parameters are only assigned if undefined. Bug: T399350 Change-Id: Id584d38433b4a8122c8c15d7ca6af1aadea38c08
Change-Id: Ib685bc901911df950f092647110d44fbe0daec75
Bug: T397245 Change-Id: I0a1f91795be7db337eedb2adf29301b9029d8681
Change-Id: I59e636b86dd9d9866852bcfa194bd9844058ecd9
updateForListener is async, and calling it twice in parallel causes rendering problems, as the action list can change while it is running. After updateForListener has run (twice) call updatePositions. Also make updatePositions debounced as it is can be called multiple times from a single action. Change-Id: I559cfd09c200f3dd07e2881770202cf7da1c045d
New changes: 3484effdf Remove unnecessary store argument from getOriginalDomElements e0ee2b691 Check for /g flag in ve.dm.Document#findText, to avoid an infinite loop 190c98920 Move DebugBar.less to same module as DebugBar.js Bug: T399232 Change-Id: I12e399d4b50fe815af003d9a07998ac50dbaf2df
Change-Id: I388f521fde40e1797191d576ea11d8469de6b1be
Change-Id: I3fd675e62ff2c223f9cbee06941eeb8dc8f26c01
This matches the documented behaviour. Change-Id: I4427610ec07dd5b54998528d48ef1f24e027430e
Bug: T399676 Change-Id: Id2d7c47a037da2d81476b6b0847124617892d13f
Change-Id: Ibcc103b13a9e8a54d85e9ca12e69175343d724dc
Bug: T397948 Depends-On: Ia48194fd8c283b3a7d1157e93f977377f18610b9 Change-Id: Id9d587b3d73a339974415850621393848fab1977
Bug: T388716 Change-Id: I7066c29456ddff218b5893983adbfd52aa785709
Change-Id: I5c1e1f0db531a83c124d97266b563e40743ec61e
Bug: T388716 Change-Id: I52a688e7769372191095aa97177d6d0449f02de9
Change-Id: Ifb7fb4f5e1d72606877116a18e84c089560e14b6
…moization Change-Id: I50d2b486146caaf06079ee032ce2e02160d226bc
Change-Id: I171f9879e5ae39b868be3e100ea785feab588104
Change-Id: I8ff801c7ee5db071e28d4f03b372618e7461c85a
Change-Id: Ib3d40bff214f869e315aa2db6d84c010bb2570e6
The code that reads this attribute doesn't care what the string says. There is no comparison with "true". Any string works as long as it's not empty. Common practice in MediaWiki is to use "1". Change-Id: Ibd80ea5c4e385aea8a2673e23b4e6810ca0ffa40
Change-Id: I09e6253de66a2308ff029f0567a877eeda21253b
Why: * In the ConfirmEdit extension we need a way to know if VisualEditor is available for use ** We cannot use the VisualEditorPluginModules for this, because we need to know this in a place where we are not setting the definition of the relevant ResourceLoader modules * Therefore, we need a stable method to get this information ** We added a service in I4ad288e74763c55d18e5f3b34a694a4268c1dc4c that centralises information about VisualEditor availability and makes the code non-static to aid in testing ** We can expand this new service to allow ConfirmEdit to call a stable method that returns whether VisualEditor is available What: * Update VisualEditorAvailabilityLookup to add a ::isAvailable method that is a copy of the logic from the Hooks::isVisualAvailable method ** Modifications are made to the structure of the code to make it easier to read, but the functionality of the method has not changed * Update VisualEditorAvailabilityLookup to add a ::isEnabledForUser method ** This is a copy of the logic from Hooks::enabledForUser ** Modificatios have been made to the structure of the logic to make it easier to read * Update Hooks.php to use the ::isAvailable and ::isEnabledForUser method over the static Hooks::isVisualAvailable and ::enabledForUser methods ** This requires making Hooks::isSupportedEditPage non-static, but this is okay because the method is private and only used in a non-static context ** Because Hooks::isVisualAvailable and ::enabledForUser are private and no longer used, they are dropped without deprecation ** All existing callers to the dropped static methods are updated to use a dependency injected instance of the service (with one exception where the method cannot be made non-static as it's public) Bug: T407390 Change-Id: I01587f2e8ea06cd0862abaad4f060954c383ffbf
Why: * In I4ad288e74763c55d18e5f3b34a694a4268c1dc4c we soft-deprecated the ApiVisualEditor::isAllowedNamespace, ::getAvailableNamespaceIds, and ::isAllowedContentType methods * Later in I01587f2e8ea06cd0862abaad4f060954c383ffbf we removed the last uses of these methods that were not from PHPUnit tests * Therefore, we can now mark these methods as hard deprecated What: * Hard deprecate ApiVisualEditor::isAllowedNamespace, ::getAvailableNamespaceIds, and ::isAllowedContentType ** Doing this means that we have to drop the associated tests, as these tests will trigger a deprecation warning. Given that no code now uses these methods, it is safe to drop the tests Bug: T398193 Change-Id: I0000bfefe71735fc98b15d6cb8e765c8d96258ec
New changes: f11bfc139 karma: Remove ve.dm.InternalList and ve.dm.InternalItemNode from exclude list ac1edf257 check-excludes.js: Check if files excluded from coverage requirements still need to be 59847d01a ve.ce.Selection: Improve coverage 39ef86bd9 ve.dm.LinearData: Add getRange method f4d60d47f ve.dm.Document: Use Array loops 1e9a55656 ve.ce.KeyDownHandlerFactory: Use Maps and Sets b45f66443 Use variadic arguments for splice methods 20c4837bc Maintain keyIndexes when rebuilding InternalList 1077ab8cb ve.dm.InternalList: Fix doc warnings 9c48413bf Minor updates to InternalList's JSDocs c698d8ed5 build: Add schema validation for modules.json 6caeeb2e4 Create local linting rule for setting user input href's bd2578ef5 Revert "Maintain keyIndexes when rebuilding InternalList" Localisation Updates: cc7a1f2a1 Added files: - .eslint-plugin-local.js - build/check-excludes.js - build/eslint/no-unsanitized-href.js - build/eslint/tests/no-unsanitized-href.examples.js Bug: T322704 Change-Id: Ia7e2e3d2c25691fc815722f1fa803d47014950ba
Bug: T322704 Change-Id: I7d1d8a751081fabe36a69ba794a46ea9d4a6c796 Depends-On: I1a4118939b22c6a8af57383398972246687a7730
Why: * In a81de3a, the VisualEditor Hooks::enabledForUser method was moved to the VisualEditorAvailabilityLookup service * Code was updated to replace the use of Hooks::enabledForUser with the method in the service, but in one place we could not use dependency injection because the method is static ** In this method, Hooks::getPreferredEditor, we instead got the service from MediaWikiServices and in doing that the name of the service was incorrectly written out (missing the `VisualEditor.` prefix) * This should be fixed as it breaks the Hooks::getPreferredEditor method and any code that calls it What: * Use VisualEditorAvailabilityLookup::SERVICE_NAME instead of the incorrect service name in Hooks::getPreferredEditor Bug: T407390 Change-Id: I2279230944f6b61babd71447fe069bef1484f4ae
Change-Id: Ic09244ab91aba36b15883dd1aab9fb02d2424dca
Change-Id: Id730bc231196ed577d3d443956b39dbefa9b1422
New changes: a5bb46df2 ve.dm.(Linear|Table)Selection: Remove old signature handling a43be0405 ve.ce.ClipboardHandler test: Inline test runner 2499c3c1d Add test coverage for table slicing (copying) 1bd6c5007 ClipboardHandler tests: Add internal table copy/paste tests 0b5d81740 Make findText’s set condition use locale for lowercasing. 3ec9cff40 Enable annotateImportedData in standalone demo b70ee4a11 Tests: Make getImportedAnnotation utility shared Bug: T407301 Change-Id: I287aa2d13c0747a39cd6d0c66ded9af494da2e67
Change-Id: I5320e87d8f5b1159cfb314f52a700af1d3af3828
Bug: T407302 Change-Id: I365ce92c888590230c9bf1f1fa159bde2bd8c8c1
We wrote this to look for pure insertions because it was a requirement for our initial add-reference check, which wanted to only trigger on completely new content. This continued as the inherited behavior for checks where it makes less sense. In particular, experimental checks that are based on annotation changes don't function under this paradigm. Changing this behavior allows the external link experimental check to work when adding an external link to existing text. Helpers/wrappers are added in order to preserve the existing behavior for add reference. Change-Id: I33e465ee2f20c4a9ae825038089df34f97b903bd
This is just for convenience, because it's easy to forget to return an array when you're abandoning a listener early. Change-Id: Ie4d193dc01e16955cdddedcd6bc578e0b99bab55
Allow matchItems to specifiy their own case sensitivity, and make term comparisons i18n-safer. Bug: T407301 Depends-On: I7b72173489ca69601b19e823f2a9fe975b4af512 Change-Id: If0319dbcd298549183a58a6af0fef97f38f8de68
Change-Id: Ie483df053da0765c9675d3ec14690c3911e0629f
* GHSA-rx8g-88g5-qh64 Change-Id: I6496b18703a1a394f3ab5df68f86fa5ce2aa8a2d
Change-Id: I0a61bb27d227154b2e6b2c1eda7326359c6c7686
* glob: 10.4.5, 7.1.7, 7.2.3, 8.1.0 → 10.5.0, 7.1.7, 7.2.3, 8.1.0 * GHSA-5j98-mcp5-4vw2 * js-yaml: 3.14.1, 4.1.0 → 3.14.2, 4.1.1 * GHSA-mh29-5h37-fv8m Change-Id: I8c817cea628848d15c3ade04575986fc3496feed
Change-Id: If61c20d06be7bdae179bf952f209c2ef1b22006a
Change-Id: Ibf769a0dac820fa348a74509547fa2ddb0cdbbc5
Change-Id: I7b048bd6ecacca19ba6819b82975ecd91cc9bd87
Change-Id: Iaa02813e131e7784b208c4a7272777169a08b1e7
* @wdio/junit-reporter: 9.15.0 → 9.23.2 * @wdio/local-runner: 9.15.0 → 9.23.2 * @wdio/spec-reporter: 9.15.0 → 9.23.2 * undici: 6.21.3, 7.10.0 → 6.23.0, 7.18.2 * GHSA-g9mf-h72j-4rw9 Change-Id: Ib678026cfe1559f4f77bb49170e3e360e7bee20a
Change-Id: I7054e7d58c4a684e8f7eb0e6a356a83475cd3e48
* diff: 5.2.0, 8.0.3 → 5.2.2, 8.0.3 * GHSA-73rr-hh4g-fpgx * lodash: 4.17.21 → 4.17.23 * GHSA-xxjr-mmjv-4gpg Change-Id: Ied9378a1c58e289386831efa7741e7ca167a0cc9
Change-Id: I71c79d4f862efc75d8d538c5fcb00ba4c68c58c5
Change-Id: I5c2c5a688bb7c632768e4bf40864473f164ad113
github-actions
bot
force-pushed
the
weirdgloop/repo-sync
branch
from
25a3853 to
80cf709
Compare
Change-Id: I5293780f018f23c37c04db90133bea820c64e517
Change-Id: Ib10b8ca30ade799d0a63e2dec92767cebed29104
* ajv: 6.12.6, 8.17.1 → 6.14.0, 8.18.0 * GHSA-2g4f-4pwh-qvx6 * basic-ftp: 5.0.5 → 5.2.0 * GHSA-5rq4-664w-9x2c * fast-xml-parser: 5.2.5 → 5.4.1 * GHSA-37qj-frw5-hhjh * GHSA-fj3w-jwp8-x2g3 * GHSA-jmr7-xgp7-cmfj * GHSA-m7jm-9gc2-mpf2 * markdown-it: 14.1.0 → 14.1.1 * GHSA-38c4-r59v-3vqw Change-Id: I88a6642afc71b8b261006f8011bef12388e3ec4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.