Skip to content

Fix [45277]: Invalid breadcrumb module json-ld output#3

Open
weeblr wants to merge 180 commits into5.3-devfrom
weeblr-45277
Open

Fix [45277]: Invalid breadcrumb module json-ld output#3
weeblr wants to merge 180 commits into5.3-devfrom
weeblr-45277

Conversation

@weeblr
Copy link
Copy Markdown
Owner

@weeblr weeblr commented Apr 11, 2025

Pull Request for Issue # 45277.

Summary of Changes

Changed JSON-LD output of breadcrumb module to be compliant with Google specification

Testing Instructions

Actual result BEFORE applying this Pull Request

Joomla breadcrumb module outputs something similar to:

{
    "@context": "https://schema.org",
    "@type": "BreadcrumbList",
    "@id": "https://example.com/#/schema/BreadcrumbList/17",
    "itemListElement": [
        {
            "@type": "ListItem",
            "position": 1,
            "item": {
                "@id": "https://example.com/",
                "name": "Home"
            }
        },
        {
            "@type": "ListItem",
            "position": 2,
            "item": {
                "@id": "https://example.com/blog/",
                "name": "Blog"
            }
        },
        {
            "@type": "ListItem",
            "position": 3,
            "item": {
                "name": "Article T6"
            }
        }
    ]
}

Expected result AFTER applying this Pull Request

Valid json-ld is similar to:

{
    "@context": "https://schema.org",
    "@type": "BreadcrumbList",
    "@id": "https://example.com/#/schema/BreadcrumbList/17",
    "itemListElement": [
        {
            "@type": "ListItem",
            "position": 1,
            "name": "Home",
            "item": "https://example.com/"
        },
        {
            "@type": "ListItem",
            "position": 2,
            "name": "Blog",
            "item": "https://example.com/blog/"
        },
        {
            "@type": "ListItem",
            "position": 3,
            "name": "Article T6"
        }
    ]
}

The change is in the details of each ListItem:

Bad:

{
"@type": "ListItem",
"position": 2,
"item": {
"@id": "https://example.com/blog/",
"name": "Blog"
}
},

Good:

{
"@type": "ListItem",
"position": 2,
"name": "Blog",
"item": "https://example.com/blog/"
},

Ref: https://developers.google.com/search/docs/appearance/structured-data/breadcrumb

Documentation Changes Required

MacJoom and others added 30 commits December 28, 2024 20:24
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
…oomla#44807)

* Composer update symfony/process

* Update composer.lock
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
* Combine multiple unset call into one call

* Remove unnecessary blank lines

* Move comments to right position

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Harald Leithner <leithner@itronic.at>

* Update libraries/src/User/User.php

Co-authored-by: Harald Leithner <leithner@itronic.at>
…44982)

* Change isset($var) && multiple times to one call

* Remove redundant checks

* Update components/com_users/src/View/Profile/HtmlView.php

---------

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
* Change list() to array destruct for libraries code
…oomla#44970)

* Change list() to array destruct for modules and plugins code

---------

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
* Add deprecation message to content modules

---------

Co-authored-by: Quy <quy@nomonkeybiz.com>
richard67 and others added 30 commits April 3, 2025 16:09
* Language update

* Language update

* Language update

* Language update

* Language update

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Some simple grammar fixes in some code comments

Code review

Signed-off-by: BrianTeeman <brian@teeman.net>
Signed-off-by: BrianTeeman <brian@teeman.net>
When a folder is empty and you have the information bar open then the text of the infobar is partially hidden

Signed-off-by: BrianTeeman <brian@teeman.net>
Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
* Fix PHP deprecation in mod_languages

* Fix PHP deprecation in mod_languages
Including just the id of the breadcrumb markup is invalid.
… Resize plugin (joomla#45311)

Fix issue joomla#44862 in the Media Action - Resize plugin where images are resized unnecessarily when only one dimension (width or height) is set.

The logic has been updated to evaluate width and height independently. The plugin now only resizes if the image exceeds a defined constraint.

---------

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…g by multiple categories (joomla#45353)

Pull Request for Issue joomla#45303 

This PR fixes a bug where creating a new article after filtering by multiple categories (e.g. "News" and "Events") incorrectly displays all custom fields from all those categories on the "Fields" tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.