This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Changed how foreground image is created to prevent "a.indexOf" is not…#52
Open
thiervoj wants to merge 1 commit intowebsanova:masterfrom
thiervoj:master
Open
Changed how foreground image is created to prevent "a.indexOf" is not…#52thiervoj wants to merge 1 commit intowebsanova:masterfrom thiervoj:master
thiervoj wants to merge 1 commit intowebsanova:masterfrom
thiervoj:master
Conversation
… a function problem
|
This solved bug for me too |
|
Worked for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to add an image in foreground a got an "Uncaught TypeError: a.indexOf is not a function" error.
I found that it was coming from the lines that create the image, especially the .load function.
So I just switched from jQuery to vanilla js and it works.
EDIT
I found that the problem came from jQuery's
.load()function, we now have to call the.on('load')function and it works. I found it here :http://stackoverflow.com/a/37915907/5313100
So instead of switching from jQuery to vanilla in my commit, I could just have changed from the
loadfunction to theonfunction, the result would be the same 😄