This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Open
Conversation
When not using a proper src, chrome displays a thin gray border around the image. I have set the src to a 1x1 transparent pixel using a base64 encoded value
The transparent pixel was not enough for thin thin border to be removed in Firefox (it was for chrome). Removing `crossOrigin` however did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a thin grey border around the embedded
img. This is something chrome does when thesrcis empty (or invalid). One approach is to use padding of the image as opposed to width/height and another solution is to use a 1x1 transparent pixel for the src.While i was at it, i also fixed the readme text (issue #14)