Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| background-color: #2f85d0; | ||
| } | ||
|
|
||
| /* Success */ |
Member
There was a problem hiding this comment.
Please avoid these changes, it is only about react, not styles
| ? `${supporter.name || supporter.slug}'s avatar` | ||
| : "avatar") | ||
| } | ||
| onError={this._handleImgError} |
Member
There was a problem hiding this comment.
Why this was just removed?
| "clean-printable": "rimraf --glob src/content/**/printable.mdx", | ||
| "preclean": "run-s clean-dist clean-printable", | ||
| "clean": "rimraf src/content/**/_*.mdx src/**/_*.json repositories/*.json", | ||
| "clean": "rimraf --glob src/content/**/_*.mdx src/**/_*.json repositories/*.json", |
Member
|
Also please reabase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade React to v19
Closes #7920
What changed
Dependencies upgraded
reactandreact-dom: 17.0.2 -> 19.1.0react-tiny-popover: 5 -> 8.1.6react-helmet-async: 2.0.5 -> 3.0.0@react-spring/web: 9.7.5 -> 10.0.3react-visibility-sensorremovedThis package uses
ReactDOM.findDOMNode(), which was removed in React 19. BothContributors.jsxandSupport.jsxnow use the nativeIntersectionObserverAPIto achieve the same lazy-load behavior, with no additional dependencies.
SidebarItem.jsxrefactoredConverted from a class component to a functional component to eliminate the
UNSAFE_componentWillReceivePropslifecycle method, which React 19 no longer supports.index.jsxupdatedReplaced the legacy
ReactDOM.render/ReactDOM.hydratecalls withcreateRootandhydrateRootfromreact-dom/client, as required by React 18+.server.jsxupdatedreact-helmet-asyncv3 with React 19 no longer populates the helmet context duringSSR (React 19 handles head tags natively). Added a null guard to prevent a crash in
the static site generator.
Configuration/components.jsupdatedreact-tiny-popoverv8 switched to a named export and renamed thepositionprop topositions. Updated the import and JSX accordingly.package.jsonscripts fixedrimrafv6 requires an explicit--globflag for glob patterns. Two scripts(
cleanandclean-printable) were missing this flag, causing them to silently donothing on Node 20+.
Testing
npm start- dev server runs cleanly, no React warnings in the browser consolenpm run build- production and SSG builds complete successfullynpm run jest- all 27 tests passLet me know if anything needs changing or if I missed something.