docs: fix lodash dependency guidance in authoring libraries guide#7903
Open
chirag-patil625 wants to merge 1 commit intowebpack:mainfrom
Open
docs: fix lodash dependency guidance in authoring libraries guide#7903chirag-patil625 wants to merge 1 commit intowebpack:mainfrom
chirag-patil625 wants to merge 1 commit intowebpack:mainfrom
Conversation
lodash is a direct dependency of the library (imported via require/import), so it should be listed in dependencies, not devDependencies. It should also not be referred to as a peerDependency. The externals config prevents it from being bundled, while listing it in dependencies ensures it gets installed when users install the library. Fixes webpack#6896
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lodash is a direct dependency of the library (imported via require/import), so it should be listed in dependencies, not devDependencies. It should also not be referred to as a peerDependency. The externals config prevents it from being bundled, while listing it in dependencies ensures it gets installed when users install the library.
Fixes #6896
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI